fix: support overloaded system functions in system libraries #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vdrg
force-pushed
the
vdrg/fix-library-imports
branch
from
6aaed39 to
007be2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodeCallwas unable to differentiate between overloaded system functions, so i needed to manually construct the selector withencodeWithSelector.i had to add the ability for codegen to parse struct definitions from source files in order to generate full function signatures. this adds one restriction when writing systems: you can't import types from the generated libraries themselves. if this is done, when generating for the first time the system libraries won't be available and it will fail when attempting to find type definitions.
i also punted on being able to import structs from non-relative paths and use them in function signatures. i didn't need it and it was a bit more complicated, but lmk if you think that is important to add.